SPLAT-2167: Added dedicated hosts support for AWS #1419
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
vr4manta
force-pushed
the
SPLAT-2167
branch
from
ea9394f to
d83d3fc
Compare
|
/test all |
1 similar comment
|
/test all |
|
/test all |
|
/test all |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial |
|
@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d3e6260-b0cb-11f0-937d-265094b680a5-0 |
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Leaving a review of the validation implementation as part of reviewing openshift/api#2484
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/test all |
vr4manta
force-pushed
the
SPLAT-2167
branch
2 times, most recently
from
02a435f to
2ebab11
Compare
|
/test all |
|
/retest |
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Validations on the webhook LGTM
openshift-merge-robot
added
the
needs-rebase
|
|
||
| // Ensure that Kube tests run privileged (like they do upstream) | ||
| testContext.CreateTestingNS = func(ctx context.Context, baseName string, c kclientset.Interface, labels map[string]string) (*corev1.Namespace, error) { | ||
| /*testContext.CreateTestingNS = func(ctx context.Context, baseName string, c kclientset.Interface, labels map[string]string) (*corev1.Namespace, error) { |
There was a problem hiding this comment.
yeah, this is what is causing the crazy dependencies. I need to finish testing w/ this commented out. If all goes well, I will clean this up.
openshift-merge-robot
removed
the
needs-rebase
|
/test all |
vr4manta
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
5 participants
SPLAT-2167
Changes
Dependencies